diff --git a/config/config.go b/config/config.go index c284627..812e00e 100644 --- a/config/config.go +++ b/config/config.go @@ -24,7 +24,6 @@ type Config struct { } Date struct { MinuteGranularity int // Restricts the minutes on which office hours can start and end to multiples of it. - MaxDuration int // Limits the length of office hours to minutes EarliestStartTime struct { Hour int Minute int @@ -104,10 +103,6 @@ func validateConfig(conf *Config) error { err = fmt.Errorf("Validating config: Earliest start time minute must be between 0 and 60, but is %d.", conf.Date.EarliestStartTime.Minute) log.Println(err.Error()) } - if !(conf.Date.MaxDuration >= conf.Date.MinuteGranularity && conf.Date.MaxDuration <= 4*60) { - err = fmt.Errorf("Validating config: Maximum duration must be between %d minute and 4 hours, but is %d.", conf.Date.MinuteGranularity, conf.Date.MaxDuration) - log.Println(err.Error()) - } if !(conf.Date.LatestStartTime.Hour >= 0 && conf.Date.LatestStartTime.Hour <= 23) { err = fmt.Errorf("Validating config: Latest start time hour must be between 0 and 23, but is %d.", conf.Date.LatestStartTime.Hour) log.Println(err.Error()) diff --git a/config/config.json b/config/config.json index 2e78982..40b1bb3 100644 --- a/config/config.json +++ b/config/config.json @@ -7,7 +7,6 @@ }, "date": { "minuteGranularity": 5, - "maxDuration": 120, "earliestStartTime": { "hour" : 8, "minute" : 0 diff --git a/controllers/addOfficeHourHandler.go b/controllers/addOfficeHourHandler.go index 816a874..56289e7 100644 --- a/controllers/addOfficeHourHandler.go +++ b/controllers/addOfficeHourHandler.go @@ -16,7 +16,6 @@ type maskData struct { Courses []models.Course Rooms []models.Room MinuteGranularity int - MaxDuration int EarliestStartTime struct { Hour int Minute int @@ -110,8 +109,8 @@ func (b *BaseHandler) AddOfficeHourHandler(w http.ResponseWriter, req *http.Requ if err != nil { errors = append(errors, "Die Dauer muss eine ganze Zahl sein.") } - if !(duration >= b.config.Date.MinuteGranularity && duration <= b.config.Date.MaxDuration && duration%b.config.Date.MinuteGranularity == 0) { - errors = append(errors, fmt.Sprintf("Sprechstunden müssen zwischen %d und %d Minuten lang sein.", b.config.Date.MinuteGranularity, b.config.Date.MaxDuration)) + if !(duration >= b.config.Date.MinuteGranularity && duration <= 120 && duration%b.config.Date.MinuteGranularity == 0) { + errors = append(errors, fmt.Sprintf("Sprechstunden müssen zwischen %d und 120 Minuten lang sein.", b.config.Date.MinuteGranularity)) } roomname := req.FormValue("raumname") @@ -145,7 +144,6 @@ func (b *BaseHandler) AddOfficeHourHandler(w http.ResponseWriter, req *http.Requ courses, rooms, b.config.Date.MinuteGranularity, - b.config.Date.MaxDuration, b.config.Date.EarliestStartTime, b.config.Date.LatestStartTime, courseid, diff --git a/controllers/timetable.go b/controllers/timetable.go index 1f9b413..0d7b379 100644 --- a/controllers/timetable.go +++ b/controllers/timetable.go @@ -51,7 +51,7 @@ func (b *BaseHandler) printTimetable(timetable map[models.Date]map[int]models.Of return template.HTML("

Aktuell sind keine passenden Sprechstunden eingetragen.

") } var tableBody string - for hour := b.config.Date.EarliestStartTime.Hour; hour < b.config.Date.LatestStartTime.Hour+b.config.Date.MaxDuration/60; hour += 1 { + for hour := 8; hour < 19; hour += 1 { for minute := 0; minute < 60; minute += b.config.Date.MinuteGranularity { tableBody += "" if minute == 0 { diff --git a/dummydatasqlite.sql b/dummydatasqlite.sql index a936c8c..f093505 100644 --- a/dummydatasqlite.sql +++ b/dummydatasqlite.sql @@ -15,7 +15,6 @@ INSERT INTO `course` (name) VALUES ('Analysis I'), ('Analysis II (engl.)'), ('Analysis II'), -('Applied Proof Theory'), ('Aussagen- und Prädikatenlogik'), ('Automaten, Formale Sprachen und Entscheidbarkeit'), ('Banach- und C*-Algebren'), diff --git a/templating/templates/addMask.html b/templating/templates/addMask.html index ab7ed6a..1b36f24 100644 --- a/templating/templates/addMask.html +++ b/templating/templates/addMask.html @@ -90,7 +90,7 @@