From b2f094547390a914527628137e283871b0ff268c Mon Sep 17 00:00:00 2001 From: Gonne Kretschmer Date: Mon, 6 Nov 2023 12:47:55 +0100 Subject: [PATCH] Improve comment explaining metrics selection --- nixos/roles/prometheusNodeExporter.nix | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/nixos/roles/prometheusNodeExporter.nix b/nixos/roles/prometheusNodeExporter.nix index 59cacc1..9587b2f 100644 --- a/nixos/roles/prometheusNodeExporter.nix +++ b/nixos/roles/prometheusNodeExporter.nix @@ -5,8 +5,11 @@ enable = true; port = 9100; # Aligned with https://git.rwth-aachen.de/fsdmath/server/prometheus/-/blob/main/node_exporter/etc/default/prometheus-node-exporter - # Original reasons are for these lists are unknown, but along the lines - # “This looks useless for VMs, but that seems nice.” + # It was compiled along the following steps: + # 1. Does the current Debian release supports the collector? + # 2. Is the collector depracated in the latest release? + # 3. Could you probably use the collected metrics for monitoring or are they useless because they make no sense in our context + # (e.g. power adapter inside a VM, use fibre port connection)? disabledCollectors = [ "arp" "bcache"