Fachschaft/nixConfig
5
2
Fork 2
Code Issues 7 Pull requests Projects 1 Wiki Activity

nerf/impermanence #13

Merged
nerf merged 6 commits from nerf/nixConfig:nerf/impermanence into main 2023-10-06 08:08:50 +00:00
Conversation 1 Commits 6 Files changed 6 +113
nerf commented 2023-09-30 15:45:51 +00:00
Owner
Copy link

Impermanence support is here

Impermanence support is here
nerf added 2 commits 2023-09-30 15:45:52 +00:00
nerf added the
Kind/Feature
 label 2023-09-30 21:15:24 +00:00
nerf added 1 commit 2023-10-01 09:54:46 +00:00
nerf added 1 commit 2023-10-01 10:00:01 +00:00
Gonne reviewed 2023-10-02 06:17:16 +00:00
README.md Outdated
@ -39,0 +51,4 @@
to interact with this, as most configuration files will be in the nix store anyway. If the application wants these nix
store files in certain directories you should use `environment.etc` family of options (consult the nixos documentation
for this). This is for mutable files that are not core application data. (Like ssh keys, for a mailserver one could
think about the hash files (not the db files) of an alias map (if one don't want to manage that with
Gonne commented 2023-10-02 06:10:58 +00:00
Owner
Copy link

don't -> doesn't

`don't` -> `doesn't`
Gonne marked this conversation as resolved
nixos/roles/default.nix Outdated
@ -1,4 +1,32 @@
{ ... } : {
{pkgs, config, lib, ...} : {
Gonne commented 2023-10-02 06:17:00 +00:00
Owner
Copy link

If #12 is merged, this diff will probably change and be easier to review. Before that, I see that there are some differences (e.g. users.root.hashedPassword = "!";) but I won't search them all and judge.

If #12 is merged, this diff will probably change and be easier to review. Before that, I see that there are some differences (e.g. ` users.root.hashedPassword = "!";`) but I won't search them all and judge.
nerf commented 2023-10-02 09:53:43 +00:00
Author
Owner
Copy link

Oh, something crept into here, that shouldn't be in here. (But it doesn't make a difference after both are merged).
But semantically here should only be the impermanence line and the rest of the changes introduced in [#12].

But they should be the same [#12] should only have more

Oh, something crept into here, that shouldn't be in here. (But it doesn't make a difference after both are merged). But semantically here should only be the impermanence line and the rest of the changes introduced in [#12]. But they should be the same [#12] should only have more
👍 1
Gonne marked this conversation as resolved
nerf added 1 commit 2023-10-02 09:56:03 +00:00
Gonne requested changes 2023-10-03 20:38:50 +00:00
README.md Outdated
@ -39,0 +49,4 @@
If you keep your application data (like recommended) on a separate partition, the chances are you don't need
to interact with this, as most configuration files will be in the nix store anyway. If the application wants these nix
store files in certain directories you should use `environment.etc` family of options (consult the nixos documentation
Gonne commented 2023-10-03 20:38:16 +00:00
Owner
Copy link

Comma after if-clause

Comma after `if`-clause
nerf marked this conversation as resolved
nerf added 1 commit 2023-10-04 21:42:24 +00:00
nerf requested review from Gonne 2023-10-04 21:44:18 +00:00
Gonne approved these changes 2023-10-05 07:55:14 +00:00
Dismissed
nerf force-pushed nerf/impermanence from fb002f7c82 to 10db771ee4 2023-10-05 21:44:11 +00:00 Compare
nerf dismissed Gonne's review 2023-10-05 21:44:12 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

nerf commented 2023-10-05 21:49:29 +00:00
Author
Owner
Copy link

rebased changes onto main, needs review again (and the diff should be very clear now)

rebased changes onto main, needs review again (and the diff should be very clear now)
Gonne approved these changes 2023-10-06 07:09:12 +00:00
nerf merged commit 35854e6065 into main 2023-10-06 08:08:50 +00:00
nerf deleted branch nerf/impermanence 2023-10-06 08:08:50 +00:00
nerf referenced this pull request from a commit 2023-10-06 08:08:51 +00:00
Fixed a comma Gonne found [#13]
Sign in to join this conversation.
Reviewers
No reviewers
Gonne
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Fachschaft/nixConfig#13
No description provided.
Delete branch "nerf/nixConfig:nerf/impermanence"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?