Fachschaft/nixConfig
5
2
Fork 2
Code Issues 7 Pull requests Projects 1 Wiki Activity

ghatanothoa: Neues Jitsi #17

Merged
nerf merged 3 commits from Gonne/nixConfig:ghatanothoa into main 2023-10-23 18:14:57 +00:00
Conversation 0 Commits 3 Files changed 4 +120
Gonne commented 2023-10-20 21:12:59 +00:00
Owner
Copy link
No description provided.
Gonne added 2 commits 2023-10-20 21:13:00 +00:00
nerf requested changes 2023-10-21 09:21:11 +00:00
nerf left a comment
Owner
Copy link

We probably want additional persistence of /var/lib/jisti-meet and /var/lib/prosody

Also is jitsi tied to hard to the machine? Can't we make a role out of it. Or a module with a little amount of options?
If that is possible I would prefer that.

We probably want additional persistence of `/var/lib/jisti-meet` and `/var/lib/prosody` Also is jitsi tied to hard to the machine? Can't we make a role out of it. Or a module with a little amount of options? If that is possible I would prefer that.
nixos/machines/ghatanothoa/configuration.nix Outdated
@ -0,0 +3,4 @@
imports = [
./hardware-configuration.nix
(import ./jitsi.nix flake-inputs)
nerf commented 2023-10-21 09:13:26 +00:00
Owner
Copy link

jitsi.nix does not use flake-inputs ever, why not scratch that parameter from the module and don't apply it here

jitsi.nix does not use flake-inputs ever, why not scratch that parameter from the module and don't apply it here
nerf marked this conversation as resolved
nixos/machines/ghatanothoa/jitsi.nix Outdated
@ -0,0 +1,23 @@
flake-inputs:
nerf commented 2023-10-21 09:20:05 +00:00
Owner
Copy link

We never use this input, so why not scratch it

We never use this input, so why not scratch it
nerf marked this conversation as resolved
nixos/machines/ghatanothoa/jitsi.nix Outdated
@ -0,0 +19,4 @@
services.nginx.virtualHosts."meet.mathebau.de".enableACME = false;
services.nginx.virtualHosts."meet.mathebau.de".forceSSL = false;
networking.firewall.allowedTCPPorts = [ 80 443 ];
networking.firewall.allowedUDPPorts = [ 10000 ];
nerf commented 2023-10-21 09:15:14 +00:00
Owner
Copy link

isn't this handled by services.jitsi-videobridge.openFirewall = true; If it is, I would not want to have that again explicitly. (or at least a comment why we want to set it explicitly again). (Or maybe I'm wrong)

isn't this handled by `services.jitsi-videobridge.openFirewall = true;` If it is, I would not want to have that again explicitly. (or at least a comment why we want to set it explicitly again). (Or maybe I'm wrong)
nerf marked this conversation as resolved
Gonne was assigned by nerf 2023-10-21 09:24:21 +00:00
Gonne added 1 commit 2023-10-23 15:43:37 +00:00
Gonne force-pushed ghatanothoa from 41c4af643d to 4b0c3f7948 2023-10-23 15:59:55 +00:00 Compare
nerf requested changes 2023-10-23 16:20:50 +00:00
nixos/modules/jitsi.nix Outdated
@ -0,0 +15,4 @@
enable = mkEnableOption "mathebau jitsi service";
hostName = mkOption {
type = str;
default = null;
nerf commented 2023-10-23 16:17:42 +00:00
Owner
Copy link

I think setting default = null; is not the same as setting no default.
I guess you want no default so just delete the line.
(See lengthy reference)

I think setting `default = null;` is not the same as setting no default. I guess you want no default so just delete the line. (See [lengthy reference](https://nixos.org/nixos/manual/#sec-writing-modules))
Gonne marked this conversation as resolved
Gonne force-pushed ghatanothoa from 4b0c3f7948 to bb93d3aed5 2023-10-23 17:06:09 +00:00 Compare
nerf approved these changes 2023-10-23 18:14:26 +00:00
nerf merged commit bb93d3aed5 into main 2023-10-23 18:14:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
nerf
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Gonne
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Fachschaft/nixConfig#17
No description provided.
Delete branch "Gonne/nixConfig:ghatanothoa"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?