Fachschaft/nixConfig
5
2
Fork 2
Code Issues 7 Pull requests 1 Projects 1 Wiki Activity

ghatanothoa: Neues Jitsi #17

Merged
nerf merged 3 commits from Gonne/nixConfig:ghatanothoa into main 2023-10-23 18:14:57 +00:00
Conversation 0 Commits 3 Files changed 4 +24
2 changed files with 24 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 4318950142 - Show all commits

1
nixos/machines/ghatanothoa/configuration.nix
View file

@ -3,6 +3,7 @@ flake-inputs:
imports = [ imports = [
./hardware-configuration.nix ./hardware-configuration.nix
(import ./jitsi.nix flake-inputs)
nerf marked this conversation as resolved Outdated
nerf commented 2023-10-21 09:13:26 +00:00
Outdated
Review
Copy link

jitsi.nix does not use flake-inputs ever, why not scratch that parameter from the module and don't apply it here

jitsi.nix does not use flake-inputs ever, why not scratch that parameter from the module and don't apply it here
../../roles ../../roles
./network.nix ./network.nix
]; ];

23
nixos/machines/ghatanothoa/jitsi.nix Normal file
View file

@ -0,0 +1,23 @@
flake-inputs:
nerf marked this conversation as resolved Outdated
nerf commented 2023-10-21 09:20:05 +00:00
Outdated
Review
Copy link

We never use this input, so why not scratch it

We never use this input, so why not scratch it
{pkgs, config, lib, modulesPath, ...}: {
imports = [(modulesPath + "/services/web-apps/jitsi-meet.nix")];
services.jitsi-meet = {
enable = true;
hostName = "meet.mathebau.de";
config = {
defaultLang = "de";
};
};
services.jitsi-videobridge = {
openFirewall = true;
nat = {
publicAddress = "130.83.2.184";
localAddress = "192.168.0.25";
};
};
services.nginx.virtualHosts."meet.mathebau.de".enableACME = false;
services.nginx.virtualHosts."meet.mathebau.de".forceSSL = false;
networking.firewall.allowedTCPPorts = [ 80 443 ];
networking.firewall.allowedUDPPorts = [ 10000 ];
nerf marked this conversation as resolved Outdated
nerf commented 2023-10-21 09:15:14 +00:00
Outdated
Review
Copy link

isn't this handled by services.jitsi-videobridge.openFirewall = true; If it is, I would not want to have that again explicitly. (or at least a comment why we want to set it explicitly again). (Or maybe I'm wrong)

isn't this handled by `services.jitsi-videobridge.openFirewall = true;` If it is, I would not want to have that again explicitly. (or at least a comment why we want to set it explicitly again). (Or maybe I'm wrong)
}