[#33] Refactored existing network config #34

nerf · 2024-03-31T23:44:21Z

nerf commented

2024-03-31 23:44:21 +00:00

Refactored existing network config, in a way that one only needs to supply an ip address.
No ipv6 support as of yet. (As if we would get v6 support in the next 15 years).
Also we need to get our interface names consistent in the Xen config. It shouldn't be
hard to extend this module by an optional setting to set the name though.

Refactored existing network config, in a way that one only needs to supply an ip address. No ipv6 support as of yet. (As if we would get v6 support in the next 15 years). Also we need to get our interface names consistent in the Xen config. It shouldn't be hard to extend this module by an optional setting to set the name though.

nerf added the

Kind/Enhancement

Priority

Medium

labels 2024-03-31 23:44:21 +00:00

nerf added 1 commit 2024-03-31 23:44:22 +00:00

[#33 ] Refactored existing network config bfc36a9a44

nerf referenced this pull request

2024-03-31 23:45:43 +00:00

Refactor Networking #33

Gonne requested changes 2024-04-01 14:54:08 +00:00

Dismissed

nixos/modules/vmNetwork.nix Outdated

					
				@ -0,0 +18,4 @@

				    ;

				  cfg = config.vmNetwork;

				in {

				  imports = [];

Gonne commented

2024-04-01 14:53:46 +00:00

Ist es üblich oder notwendig, leere Imports mit hinzuschreiben?

nerf commented

2024-04-02 14:05:11 +00:00

I'm not sure if it is required (I would guess no). But I kind of find it idiomatic to put it there. We should agree if we do it or not and then enforce it across the whole codebase.

Gonne commented

2024-04-02 16:42:59 +00:00

I don't mind. One precedent is https://nixos.wiki/wiki/NixOS_modules#Example which leaves it out. 🤷

nixos/modules/vmNetwork.nix Outdated

					
				@ -0,0 +41,4 @@

				        addrLastInt = builtins.toString (toInt (last addr) + 127);

				      in

				        concatStringsSep "." (addrInit ++ [addrLastInt]);

				      nameservers = ["130.83.2.22" "130.83.56.60" "130.83.22.60" "130.82.22.63"];

Gonne commented

2024-04-01 14:52:38 +00:00

Hierzu sollten wir die Quelle https://www.hrz.tu-darmstadt.de/services/it_services/nameserver_dns/index.de.jsp verlinken. Aus dieser geht hervor, dass die Zeile in Reihenfolge der Hostnamen

      nameservers = ["130.83.22.63" "130.83.22.60" "130.83.56.60"];

lauten sollte. Der Server unter 130.83.2.22 hingegen liefert mir keine Antworten (mehr).

Hierzu sollten wir die Quelle https://www.hrz.tu-darmstadt.de/services/it_services/nameserver_dns/index.de.jsp verlinken. Aus dieser geht hervor, dass die Zeile in Reihenfolge der Hostnamen ``` nameservers = ["130.83.22.63" "130.83.22.60" "130.83.56.60"]; ``` lauten sollte. Der Server unter `130.83.2.22` hingegen liefert mir keine Antworten (mehr).

nerf marked this conversation as resolved

nerf force-pushed nerf/networkConfig from bfc36a9a44 to cabd210aa6

2024-04-02 14:02:49 +00:00

Compare

nerf added the

Reviewed

Confirmed

label 2024-04-02 14:12:01 +00:00

Gonne was assigned by nerf

2024-04-02 14:12:12 +00:00

nerf self-assigned this 2024-04-02 14:12:12 +00:00

nerf requested review from Gonne 2024-04-02 14:12:27 +00:00