Fachschaft/nixConfig
5
2
Fork 2
Code Issues 7 Pull requests 2 Projects 1 Wiki Activity

[#33] Refactored existing network config #34

Merged
nerf merged 1 commit from nerf/nixConfig:nerf/networkConfig into main 2024-04-03 13:30:20 +00:00
Conversation 0 Commits 1 Files changed 3 +50 -17
nerf commented 2024-03-31 23:44:21 +00:00
Owner
Copy link

Refactored existing network config, in a way that one only needs to supply an ip address.
No ipv6 support as of yet. (As if we would get v6 support in the next 15 years).
Also we need to get our interface names consistent in the Xen config. It shouldn't be
hard to extend this module by an optional setting to set the name though.

Refactored existing network config, in a way that one only needs to supply an ip address. No ipv6 support as of yet. (As if we would get v6 support in the next 15 years). Also we need to get our interface names consistent in the Xen config. It shouldn't be hard to extend this module by an optional setting to set the name though.
nerf added the
Kind/Enhancement
Priority
Medium
 labels 2024-03-31 23:44:21 +00:00
nerf added 1 commit 2024-03-31 23:44:22 +00:00
Gonne requested changes 2024-04-01 14:54:08 +00:00
Dismissed
nixos/modules/vmNetwork.nix Outdated
@ -0,0 +18,4 @@
;
cfg = config.vmNetwork;
in {
imports = [];
Gonne commented 2024-04-01 14:53:46 +00:00
Owner
Copy link

Ist es üblich oder notwendig, leere Imports mit hinzuschreiben?

Ist es üblich oder notwendig, leere Imports mit hinzuschreiben?
nerf commented 2024-04-02 14:05:11 +00:00
Author
Owner
Copy link

I'm not sure if it is required (I would guess no). But I kind of find it idiomatic to put it there. We should agree if we do it or not and then enforce it across the whole codebase.

I'm not sure if it is required (I would guess no). But I kind of find it idiomatic to put it there. We should agree if we do it or not and then enforce it across the whole codebase.
Gonne commented 2024-04-02 16:42:59 +00:00
Owner
Copy link

I don't mind. One precedent is https://nixos.wiki/wiki/NixOS_modules#Example which leaves it out. 🤷

I don't mind. One precedent is https://nixos.wiki/wiki/NixOS_modules#Example which leaves it out. 🤷
nixos/modules/vmNetwork.nix Outdated
@ -0,0 +41,4 @@
addrLastInt = builtins.toString (toInt (last addr) + 127);
in
concatStringsSep "." (addrInit ++ [addrLastInt]);
nameservers = ["130.83.2.22" "130.83.56.60" "130.83.22.60" "130.82.22.63"];
Gonne commented 2024-04-01 14:52:38 +00:00
Owner
Copy link

Hierzu sollten wir die Quelle https://www.hrz.tu-darmstadt.de/services/it_services/nameserver_dns/index.de.jsp verlinken. Aus dieser geht hervor, dass die Zeile in Reihenfolge der Hostnamen

      nameservers = ["130.83.22.63" "130.83.22.60" "130.83.56.60"];

lauten sollte. Der Server unter 130.83.2.22 hingegen liefert mir keine Antworten (mehr).

Hierzu sollten wir die Quelle https://www.hrz.tu-darmstadt.de/services/it_services/nameserver_dns/index.de.jsp verlinken. Aus dieser geht hervor, dass die Zeile in Reihenfolge der Hostnamen ``` nameservers = ["130.83.22.63" "130.83.22.60" "130.83.56.60"]; ``` lauten sollte. Der Server unter `130.83.2.22` hingegen liefert mir keine Antworten (mehr).
nerf marked this conversation as resolved
nerf force-pushed nerf/networkConfig from bfc36a9a44 to cabd210aa6 2024-04-02 14:02:49 +00:00 Compare
nerf added the
Reviewed
Confirmed
 label 2024-04-02 14:12:01 +00:00
Gonne was assigned by nerf 2024-04-02 14:12:12 +00:00
nerf self-assigned this 2024-04-02 14:12:12 +00:00
nerf requested review from Gonne 2024-04-02 14:12:27 +00:00
Gonne approved these changes 2024-04-02 17:52:57 +00:00
nerf merged commit cabd210aa6 into main 2024-04-03 13:30:20 +00:00
nerf deleted branch nerf/networkConfig 2024-04-03 13:30:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Gonne
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Gonne
nerf
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Fachschaft/nixConfig#34
No description provided.
Delete branch "nerf/nixConfig:nerf/networkConfig"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?