Fachschaft/nixConfig
5
2
Fork 2
Code Issues 7 Pull requests Projects 1 Wiki Activity

Bragi cleanup #35

Merged
Gonne merged 3 commits from Gonne/nixConfig:bragi into main 2024-04-03 13:59:25 +00:00
Conversation 0 Commits 3 Files changed 3 +11 -9
Gonne commented 2024-04-02 07:09:46 +00:00
Owner
Copy link
No description provided.
Gonne added 1 commit 2024-04-02 07:09:47 +00:00
nerf requested changes 2024-04-02 14:09:52 +00:00
Dismissed
nerf left a comment
Owner
Copy link

Even though I think both things are no brainers, it still feels like this should be two pull requests. (Or at the very least two separate commits) (to split these interactive git rebase and interactive git add, are your friend.)

Even though I think both things are no brainers, it still feels like this should be two pull requests. (Or at the very least two separate commits) (to split these interactive git rebase and interactive git add, are your friend.)
nerf added the
Kind/Enhancement
Reviewed
Confirmed
Priority
Medium
 labels 2024-04-02 14:11:18 +00:00
Gonne was assigned by nerf 2024-04-02 14:11:36 +00:00
nerf self-assigned this 2024-04-02 14:11:36 +00:00
Gonne force-pushed bragi from 72610eb2bf to f0bd165b0c 2024-04-02 16:35:28 +00:00 Compare
Gonne requested review from nerf 2024-04-02 16:35:56 +00:00
Gonne changed title from Move secrets to machine config and improve fsaccount mirroring to Bragi cleanup 2024-04-02 16:45:46 +00:00
Gonne added 1 commit 2024-04-02 16:47:07 +00:00
Gonne requested review from Server-Minions 2024-04-02 17:52:08 +00:00
nerf force-pushed bragi from 85f3bde55d to 3f096f5205 2024-04-03 13:32:12 +00:00 Compare
Gonne force-pushed bragi from 3f096f5205 to e69c8c6efb 2024-04-03 13:41:18 +00:00 Compare
nerf approved these changes 2024-04-03 13:58:37 +00:00
nerf left a comment
Owner
Copy link

I should've noticed the missing --delete last review.

I should've noticed the missing `--delete` last review.
Gonne merged commit e69c8c6efb into main 2024-04-03 13:59:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
nerf
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Gonne
nerf
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Fachschaft/nixConfig#35
No description provided.
Delete branch "Gonne/nixConfig:bragi"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?