Fachschaft/nixConfig
5
2
Fork 2
Code Issues 11 Pull requests 1 Projects Wiki Activity

Add Nodens, a VM to install NixOS VMs #48

Merged
Gonne merged 3 commits from Gonne/nixConfig:nodens into main 2025-02-20 15:42:12 +00:00
Conversation 0 Commits 3 Files changed 5 +84 -24
Gonne commented 2024-11-29 14:12:21 +00:00
Owner
Copy link

Closes #10.

Closes #10.
Gonne added 1 commit 2024-11-29 14:12:22 +00:00
requested review from Server-Minions 2024-12-02 19:56:30 +00:00
Gonne force-pushed nodens from 765f25022d to 717f91028f 2024-12-13 16:11:14 +00:00 Compare
nerf requested changes 2025-02-20 15:19:32 +00:00
Dismissed
nerf left a comment
Owner
Copy link

someone should read the README changes, but I don't have the peace of mind right now.

someone should read the README changes, but I don't have the peace of mind right now.
nixos/flake-module.nix Outdated
@ -15,3 +15,3 @@
systemConfig =
if lib.isFunction importedConfig
then x: importedConfig (x // {flake-inputs = inputs;})
then
nerf commented 2025-02-20 15:18:29 +00:00
Owner
Copy link

I think having a separate commit for this change might make bug hunting easier if this introduces a regression.

I think having a separate commit for this change might make bug hunting easier if this introduces a regression.
nixos/machines/ghatanothoa/hardware-configuration.nix Outdated
@ -8,3 +8,3 @@
};
fileSystems."/persist" = {
device = "/dev/disk/by-uuid/e0a160ef-7d46-4705-9152-a6b602898136";
device = "/dev/disk/by-label/nixos";
nerf commented 2025-02-20 15:08:12 +00:00
Owner
Copy link

This is out of scope

This is out of scope
Gonne commented 2025-02-20 15:24:29 +00:00
Author
Owner
Copy link

I don't think so because it is alignment with the naming police introduced here.

I don't think so because it is alignment with the naming police introduced here.
nixos/machines/nodens/hardware-configuration.nix Outdated
@ -0,0 +4,4 @@
pkgs,
...
}: {
fileSystems."/" = {
nerf commented 2025-02-20 15:14:03 +00:00
Owner
Copy link

Maybe we want /tmp/ of this machine on disk, because builds can get big, or we give it a lot of RAM, but I'm unsure if we want to reserve a lot of resources for a machine that does not do anything client facing.

Maybe we want /tmp/ of this machine on disk, because builds can get big, or we give it a lot of RAM, but I'm unsure if we want to reserve a lot of resources for a machine that does not do anything client facing.
Gonne commented 2025-02-20 15:28:06 +00:00
Author
Owner
Copy link

There is currently both plenty of RAM as well as 10GB swap.

There is currently both plenty of RAM as well as 10GB swap.
Gonne force-pushed nodens from 717f91028f to 3565ac910e 2025-02-20 15:33:07 +00:00 Compare
Gonne force-pushed nodens from 3565ac910e to 77bdd979b0 2025-02-20 15:38:20 +00:00 Compare
nerf approved these changes 2025-02-20 15:41:36 +00:00
Gonne merged commit 77bdd979b0 into main 2025-02-20 15:42:12 +00:00
Gonne deleted branch nodens 2025-02-20 15:42:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
nerf
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Fachschaft/nixConfig#48
No description provided.
Delete branch "Gonne/nixConfig:nodens"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?