Fachschaft/nixConfig
5
2
Fork 2
Code Issues 11 Pull requests 1 Projects Wiki Activity

WIP: nyarlathotep: cleanup after deployment #55

Draft
Gonne wants to merge 13 commits from Gonne/nixConfig:nyarlathotep into main
pull from: Gonne/nixConfig:nyarlathotep
merge into: Fachschaft:main
Conversation 1 Commits 13 Files changed 5 +166 -35
Gonne commented 2025-03-02 10:49:09 +00:00
Owner
Copy link
No description provided.
Gonne added 9 commits 2025-03-02 10:49:10 +00:00 
This directive is supposed to prevent mail delivery loops that would be caused by portforwarding to itself.
Behind this ip address, however, there is our general mail vm and not immediately the mailinglist setup.
Gonne added 1 commit 2025-03-02 10:57:34 +00:00
requested review from Server-Minions 2025-03-02 11:01:47 +00:00
Gonne force-pushed nyarlathotep from 590ea741d0 to d7f4598be3 2025-03-02 12:39:18 +00:00 Compare
Gonne force-pushed nyarlathotep from d7f4598be3 to b3ac11ddc9 2025-03-02 13:06:28 +00:00 Compare
Gonne force-pushed nyarlathotep from b3ac11ddc9 to 9c26820b8f 2025-03-02 13:14:39 +00:00 Compare
Gonne force-pushed nyarlathotep from 9c26820b8f to c5849b8695 2025-03-02 19:38:05 +00:00 Compare
nerf requested changes 2025-03-03 10:38:07 +00:00
nerf left a comment
Owner
Copy link

First few comments

First few comments
nixos/modules/mail.nix Outdated
@ -187,0 +214,4 @@
++ ["sieve.trusted.*"]; #for macros to be able to include our redirection script
sieve.trusted = {
scripts.redirects.contents = "%{file:/tmp/virt_aliases}%"; # generated redirect script
trusted.from-addr = "sender"; # set the from-address to the original sender as specified in the MAIL FROM.
nerf commented 2025-03-02 16:03:00 +00:00
Owner
Copy link

the trusted part is to much, also see the comment at from-name below

the `trusted` part is to much, also see the comment at `from-name` below
👍 1
Gonne marked this conversation as resolved
nixos/modules/mail.nix Outdated
@ -187,0 +215,4 @@
sieve.trusted = {
scripts.redirects.contents = "%{file:/tmp/virt_aliases}%"; # generated redirect script
trusted.from-addr = "sender"; # set the from-address to the original sender as specified in the MAIL FROM.
from-name = "sender";
nerf commented 2025-03-02 16:05:15 +00:00
Owner
Copy link

I couldn't figure out what from-name or from-addr actually do. Reading the documentation I believe combined they
set the default value for the From: header of a generated mail. But I couldn't verify this in tests.
Maybe it does something different that has to do with the MAIL FROM: see comment below

I couldn't figure out what `from-name` or `from-addr` actually do. Reading the documentation I believe combined they set the default value for the `From:` header of a generated mail. But I couldn't verify this in tests. Maybe it does something different that has to do with the `MAIL FROM:` see comment below
Gonne marked this conversation as resolved
nixos/modules/mail.nix Outdated
@ -187,0 +216,4 @@
scripts.redirects.contents = "%{file:/tmp/virt_aliases}%"; # generated redirect script
trusted.from-addr = "sender"; # set the from-address to the original sender as specified in the MAIL FROM.
from-name = "sender";
return-path = "sender";
nerf commented 2025-03-02 16:06:36 +00:00
Owner
Copy link

This seems to do what we want, even though the documentation reads like it sets the Return-Path: header. But it seems to set the reverse path (which is the argument to the MAIL FROM: smtp command). Maybe it does both?

This seems to do what we want, even though the documentation reads like it sets the `Return-Path:` header. But it seems to set the reverse path (which is the argument to the `MAIL FROM:` smtp command). Maybe it does both?
nerf commented 2025-03-03 10:36:53 +00:00
Owner
Copy link

This parameter seems to control the MAIL FROM: and with this all the headers we want to set.
The documentation reads to me as if it sets the Return-Path: header. I'm unsure if it actually does it.

This parameter seems to control the `MAIL FROM:` and with this all the headers we want to set. The documentation reads to me as if it sets the `Return-Path:` header. I'm unsure if it actually does it.
Gonne marked this conversation as resolved
Gonne commented 2025-03-03 11:56:04 +00:00
Author
Owner
Copy link

So we want this?

sieve.trusted = {
            # […]
#            from-addr = "sender";  # unset
#            from-name = "sender"; # unset
            return-path = "sender"; # set the outgoing MAIL FROM to the original sender as specified in the incoming MAIL FROM.
            # […]
          };
So we want this? ```nix sieve.trusted = { # […] # from-addr = "sender"; # unset # from-name = "sender"; # unset return-path = "sender"; # set the outgoing MAIL FROM to the original sender as specified in the incoming MAIL FROM. # […] }; ```
Gonne added 1 commit 2025-03-03 11:59:26 +00:00
Gonne added 1 commit 2025-03-03 13:50:06 +00:00
requested review from nerf 2025-03-03 14:46:05 +00:00
Gonne added 1 commit 2025-03-04 06:40:04 +00:00
Gonne force-pushed nyarlathotep from 4c946968e1 to 5e0cb9ebcc 2025-03-04 08:06:09 +00:00 Compare
Gonne force-pushed nyarlathotep from 5e0cb9ebcc to d27f4b942e 2025-03-04 08:20:42 +00:00 Compare
Gonne force-pushed nyarlathotep from d27f4b942e to c24757321e 2025-03-04 10:31:18 +00:00 Compare
Gonne force-pushed nyarlathotep from c24757321e to 6271e04c10 2025-03-05 20:01:04 +00:00 Compare
nerf changed title from nyarlathotep: cleanup after deployment to WIP: nyarlathotep: cleanup after deployment 2025-03-05 20:13:27 +00:00
nerf added the
Status
Blocked
 label 2025-03-05 20:13:40 +00:00
refused to review 2025-03-05 20:14:16 +00:00
Gonne force-pushed nyarlathotep from 6271e04c10 to 19351ef316 2025-03-06 07:52:30 +00:00 Compare
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u nyarlathotep:Gonne-nyarlathotep
git checkout Gonne-nyarlathotep
Sign in to join this conversation.
Reviewers
No reviewers
nerf
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Fachschaft/nixConfig#55
No description provided.
Delete branch "Gonne/nixConfig:nyarlathotep"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?