Fachschaft/nixConfig
6
2
Fork 2
Code Issues 10 Pull requests 1 Projects Wiki Activity

Disallow apostrophies in mail addresses that we push to HRZ #76

Merged
Gonne merged 1 commit from Gonne/nixConfig:apostrophe into main 2025-04-07 15:20:40 +00:00
Conversation 3 Commits 1 Files changed 3 +65 -29
Gonne commented 2025-03-30 07:50:52 +00:00
Owner
Copy link
No description provided.
Gonne added 1 commit 2025-03-30 07:50:53 +00:00
requested review from Server-Minions 2025-03-30 07:51:09 +00:00
Gonne changed title from Disallow apostrophies in mail addresses that we push to HRZ to WIP: Disallow apostrophies in mail addresses that we push to HRZ 2025-03-30 11:13:21 +00:00
removed review request for Server-Minions 2025-03-30 11:13:24 +00:00
Gonne commented 2025-03-30 11:13:55 +00:00
Author
Owner
Copy link

Apostrophes also break our script so we want to disallow them in all mail addresses.

Apostrophes also break our script so we want to disallow them in all mail addresses.
Gonne force-pushed apostrophe from e08af81f77 to eb86511fe7 2025-03-30 17:33:32 +00:00 Compare
Gonne changed title from WIP: Disallow apostrophies in mail addresses that we push to HRZ to Disallow apostrophies in mail addresses that we push to HRZ 2025-03-30 17:33:38 +00:00
requested review from Server-Minions 2025-03-30 17:33:49 +00:00
Gonne added this to the Mail is just working milestone 2025-03-30 17:41:14 +00:00
nerf commented 2025-03-31 14:08:40 +00:00
Owner
Copy link

I will let this be open for a week, so someone with more Rust knowledge than me can give a proper review. If it doesn't happen I will just approve.
@dsimon @Peter @totallynotadolphin

I will let this be open for a week, so someone with more Rust knowledge than me can give a proper review. If it doesn't happen I will just approve. @dsimon @Peter @totallynotadolphin
nerf approved these changes 2025-04-07 13:22:21 +00:00
nerf left a comment
Owner
Copy link

This is not a real review, but we can't have this lying around forever with none, so I will approve

This is not a real review, but we can't have this lying around forever with none, so I will approve
Gonne force-pushed apostrophe from eb86511fe7 to aa210d868b 2025-04-07 15:20:05 +00:00 Compare
Gonne merged commit aa210d868b into main 2025-04-07 15:20:40 +00:00
Gonne deleted branch apostrophe 2025-04-07 15:20:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
nerf
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Mail is just working
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Fachschaft/nixConfig#76
No description provided.
Delete branch "Gonne/nixConfig:apostrophe"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?