Gonne

Gonne suggested changes for Fachschaft/nixConfig#13

2023-10-03 20:38:50 +00:00

nerf/impermanence

Gonne commented on pull request Fachschaft/nixConfig#8

2023-10-03 20:36:06 +00:00

nerf/READMETypo

Comma after if-clause

Gonne commented on pull request Fachschaft/nixConfig#8

2023-10-03 20:36:06 +00:00

nerf/READMETypo

Comma after if-clause

Gonne commented on pull request Fachschaft/nixConfig#8

2023-10-03 20:36:06 +00:00

nerf/READMETypo

Comma after if-clause

Gonne suggested changes for Fachschaft/nixConfig#8

2023-10-03 20:36:06 +00:00

nerf/READMETypo

Found two more commas.

Gonne commented on pull request Fachschaft/nixConfig#8

2023-10-03 20:31:21 +00:00

nerf/READMETypo

I not only inserted the comma but also reordered the words. Any comments on that?

Gonne commented on pull request Fachschaft/nixConfig#12

2023-10-03 20:22:05 +00:00

nerf/defaultRoles

We currently don't log Xen console logs as far as I know, but I'd like to be closer to this file. Maybe log both to console and to disk until we collect the console log?

Gonne commented on pull request Fachschaft/nixConfig#12

2023-10-03 20:18:45 +00:00

nerf/defaultRoles

I don't really care.

Gonne commented on pull request Fachschaft/nixConfig#13

2023-10-02 06:17:16 +00:00

nerf/impermanence

don't -> doesn't

Gonne commented on pull request Fachschaft/nixConfig#13

2023-10-02 06:17:16 +00:00

nerf/impermanence

If #12 is merged, this diff will probably change and be easier to review. Before that, I see that there are some differences (e.g. users.root.hashedPassword = "!";) but I won't search them all and judge.

Gonne commented on pull request Fachschaft/nixConfig#12

2023-10-02 06:08:44 +00:00

nerf/defaultRoles

Why does this user get a password? We didn't do that on our Debian machines with individual user accounts.

Gonne commented on pull request Fachschaft/nixConfig#12

2023-10-02 06:08:44 +00:00

nerf/defaultRoles

Why do they get a home directory? I would expect them to have about no personal data.

Gonne commented on pull request Fachschaft/nixConfig#12

2023-10-02 06:08:44 +00:00

nerf/defaultRoles

Does this only set the defaults in case we enable some nginx or does this enable nginx (and why)?

Gonne commented on pull request Fachschaft/nixConfig#12

2023-10-02 06:08:44 +00:00

nerf/defaultRoles

How does this file compare to the Xen-DomU config?

Gonne commented on pull request Fachschaft/nixConfig#8

2023-10-02 05:48:44 +00:00

nerf/READMETypo

Change important to important:.

Gonne commented on pull request Fachschaft/nixConfig#8

2023-10-02 05:48:44 +00:00

nerf/READMETypo

Clone capitalised

Gonne commented on pull request Fachschaft/nixConfig#8

2023-10-02 05:48:44 +00:00

nerf/READMETypo

Comma after if-clause

Gonne commented on pull request Fachschaft/nixConfig#8

2023-10-02 05:48:44 +00:00

nerf/READMETypo

At best, you first take a look at

Gonne commented on pull request Fachschaft/nixConfig#8

2023-10-02 05:48:44 +00:00

nerf/READMETypo

The

Gonne commented on pull request Fachschaft/nixConfig#8

2023-10-02 05:48:44 +00:00

nerf/READMETypo

Comma after if-clause