• Joined on 2021-01-18
Gonne pushed to kaalut at Gonne/nixConfig 2024-12-14 16:31:54 +00:00
d89b132fa1 Address first round of review
Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-14 11:20:45 +00:00
Mail machine

There is no need for system wide.

Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-14 11:15:15 +00:00
Mail machine

The flake-inputs parameter is not available as a module parameter while pkgs is supplied by the nix module system.

Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-13 17:29:29 +00:00
Mail machine

The passwords can be in one yaml file and still be exposed as different secrets by sops. This can

Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-13 17:29:29 +00:00
Mail machine

???

Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-13 17:29:29 +00:00
Mail machine

this needs a comment!

Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-13 17:29:29 +00:00
Mail machine

isn't really a problem, this means we have time to rebuild stalwart to deploy the new alias

Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-13 17:29:29 +00:00
Mail machine

maybe a comment what cthulhu should forward to us, and on which connections it handles tls

Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-13 17:29:29 +00:00
Mail machine

I HATE starttls can we burn down the hrz already?

Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-13 17:29:29 +00:00
Mail machine

I love how we kind of abuse being in a shielded environment

Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-13 17:29:29 +00:00
Mail machine

comment is outdated

Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-13 17:29:29 +00:00
Mail machine

This line needs explanation. A LOT OF IT

Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-13 17:29:29 +00:00
Mail machine

double uff

Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-13 17:29:29 +00:00
Mail machine

if the mailboxes are data on the machine, maybe the aliases should be too. This would also spare us to rebuild stalwart to update an alias

Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-13 17:29:29 +00:00
Mail machine

did you think about a more specialized type, non empty string? string matching regex? something like this?

Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-13 17:29:29 +00:00
Mail machine

does this need to be a system wide package or can we just call it in the right places?

Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-13 17:29:29 +00:00
Mail machine

this is fine because we only talk to vms and hrz which are "trusted" entities

Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-13 17:29:29 +00:00
Mail machine

ufff

Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-13 17:29:29 +00:00
Mail machine

lol

Gonne commented on pull request Fachschaft/nixConfig#47 2024-12-13 17:29:29 +00:00
Mail machine

in production?